Skip to content

bpo-33195: Doc: Deprecate Py_UNICODE in c-api/arg #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2018

Conversation

methane
Copy link
Member

@methane methane commented Apr 1, 2018

Py_UNICODE is deprecated since Python 3.3.
But the deprecation is missed in the c-api/arg document.

https://bugs.python.org/issue33195

Py_UNICODE is deprecated since Python 3.3.
But the deprecation is missed in the c-api/arg document.
``u`` (:class:`str`) [const Py_UNICODE \*]
Convert a null-terminated buffer of Unicode (UCS-2 or UCS-4) data to a Python
``u`` (:class:`str`) [const wchar_t \*]
Convert a null-terminated buffer of Unicode (UTF-16 or UCS-4) data to a Python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say

a null-terminated :c:type:`wchar_t` buffer

@methane methane added docs Documentation in the Doc dir needs backport to 3.7 labels Apr 4, 2018
@methane methane merged commit 42ec190 into python:master Apr 4, 2018
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@methane methane deleted the deprecate-pyunicode branch April 4, 2018 04:59
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2018
Py_UNICODE is deprecated since Python 3.3.
But the deprecation is missed in the c-api/arg document.
(cherry picked from commit 42ec190)

Co-authored-by: INADA Naoki <[email protected]>
@bedevere-bot
Copy link

GH-6369 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 4, 2018
Py_UNICODE is deprecated since Python 3.3.
But the deprecation is missed in the c-api/arg document.
(cherry picked from commit 42ec190)

Co-authored-by: INADA Naoki <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @methane, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 42ec190761a2e8503aaa06f0bfaaabe98749179b 3.6

methane added a commit to methane/cpython that referenced this pull request Apr 5, 2018
Py_UNICODE is deprecated since Python 3.3.
But the deprecation is missed in the c-api/arg document..
(cherry picked from commit 42ec190)

Co-authored-by: INADA Naoki <[email protected]>
methane added a commit to methane/cpython that referenced this pull request Apr 5, 2018
Py_UNICODE is deprecated since Python 3.3.
But the deprecation is missed in the c-api/arg document..
(cherry picked from commit 42ec190)

Co-authored-by: INADA Naoki <[email protected]>
@bedevere-bot
Copy link

GH-6382 is a backport of this pull request to the 3.6 branch.

methane added a commit that referenced this pull request Apr 5, 2018
Py_UNICODE is deprecated since Python 3.3.
But the deprecation is missed in the c-api/arg document.
(cherry picked from commit 42ec190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants