bpo-29922: Improve error messages in 'async with' #6352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when __aenter__() or __aexit__() return non-awaitable object.
|
Nice! Can we please backport this to 3.6? |
1st1
approved these changes
Apr 2, 2018
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6353 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
when __aenter__() or __aexit__() return non-awaitable object. (cherry picked from commit a68f2f0) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
when __aenter__() or __aexit__() return non-awaitable object. (cherry picked from commit a68f2f0) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-6354 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 4, 2018
when __aenter__() or __aexit__() return non-awaitable object. (cherry picked from commit a68f2f0) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Apr 4, 2018
when __aenter__() or __aexit__() return non-awaitable object. (cherry picked from commit a68f2f0) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
__aenter__()or__aexit__()return non-awaitable object.https://bugs.python.org/issue29922