Skip to content

bpo-23403: Bump pickle.DEFAULT_PROTOCOL to 4 #6355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2018
Merged

bpo-23403: Bump pickle.DEFAULT_PROTOCOL to 4 #6355

merged 1 commit into from
Apr 4, 2018

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Apr 2, 2018 •
edited by bedevere-bot
Loading

This makes performance better and produces shorter pickles. This change is backwards compatible up to the oldest currently supported version of Python (3.4).

https://bugs.python.org/issue23403

@ambv ambv requested review from pitrou and serhiy-storchaka April 2, 2018 23:19
serhiy-storchaka
serhiy-storchaka reviewed Apr 2, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docstrings, the module documentation, and What's New.

Misc/NEWS.d/next/Library/2018-04-02-16-10-12.bpo-23403.KG7ADV.rst Outdated
@@ -0,0 +1,3 @@
DEFAULT_PROTOCOL in pickle was bumped to 4. Protocol 4 is described in PEP
3154 and available since Python 3.4. It offers better performance and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a reStructuredText, we can add links: :mod:`pickle`, :pep:`3154`.

@ambv
Copy link
Contributor Author

ambv commented Apr 3, 2018 •
edited
Loading

Lib/test/pickletester.py:AbstractPicklerUnpicklerObjectTests.test_clear_pickler_memo is failing for CPicklerUnpicklerObjectTests only. This seems like a bug to me since it passes on the same protocol in the pure-Python implementation (PyPicklerUnpicklerObjectTests).

@pitrou Could you take a look?

serhiy-storchaka
serhiy-storchaka reviewed Apr 3, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is other mention of the default protocol 3 in the module documentation.

Regenerate Argument Clinic files and fix tests.

@ambv
Copy link
Contributor Author

ambv commented Apr 3, 2018

@serhiy-storchaka, updated the remaining comment on default protocol 3, regenerated Argument Clinic. For the failing test, see my comment above, I'm not sure what the fix should be here.

@serhiy-storchaka
Copy link
Member

I think there is a bug in C implementation. Opened bpo-33209.

serhiy-storchaka
serhiy-storchaka reviewed Apr 3, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe add a versionchanged directive somewhere in pickle.rst?

Doc/library/pickle.rst Outdated
the default protocol, and the recommended protocol when compatibility with
other Python 3 versions is required.
:class:`bytes` objects and cannot be unpickled by Python 2.x. This was
the default protocol in Python 3.0 - 3.7.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: it is preferable to use an en-dash for the version range.

Python 3.0--3.7

bpo-23403: Bump pickle.DEFAULT_PROTOCOL to 4
71d2d7b 
This makes performance better and produces shorter pickles. This change is backwards compatible up to the oldest currently supported version of Python (3.4).
@ambv
Copy link
Contributor Author

ambv commented Apr 3, 2018

Responded to remaining nits and rebased to include GH-6363. All tests pass now.

@ambv ambv merged commit c51d8c9 into python:master Apr 4, 2018
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv ambv deleted the pickle4 branch July 12, 2021 11:24
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ambv @serhiy-storchaka @bedevere-bot @the-knights-who-say-ni