bpo-32873: Remove a name hack for generic aliases in typing module #6376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Apr 4, 2018
Lib/typing.py
Outdated
| @@ -629,7 +642,10 @@ def __init__(self, origin, params, *, inst=True, special=False, name=None): | |||
| self._special = special | |||
| if special and name is None: | |||
| orig_name = origin.__name__ | |||
| name = orig_name[0].title() + orig_name[1:] | |||
| if orig_name in _normalize_alias: | |||
| name = _normalize_alias[orig_name] | |||
There was a problem hiding this comment.
name = _normalize_alias.get(orig_name, orig_name)?
There was a problem hiding this comment.
Hm, interesting suggestion, let's go with it.
|
Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6378 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 5, 2018
…ythonGH-6376) This removes a hack and replaces it with a proper mapping {'list': 'List', 'dict': 'Dict', ...}. (cherry picked from commit 2a363d2) Co-authored-by: Ivan Levkivskyi <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Apr 5, 2018
…H-6376) This removes a hack and replaces it with a proper mapping {'list': 'List', 'dict': 'Dict', ...}. (cherry picked from commit 2a363d2) Co-authored-by: Ivan Levkivskyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a hack and replaces it with a proper mapping
{'list': 'List', 'dict': 'Dict', ...}.https://bugs.python.org/issue32873