bpo-25735: math.factorial doc should mention integer return type #6420
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
The bot isn't that smart yet. File a bug report in the bot's source's github page, asking for a manual re-run. |
|
Is this necessary? I don't think anyone could realistically think it's not an integer. |
|
@chadmiller-amzn Yes, it is, but always better to specify to save developer time. |
| @@ -0,0 +1 @@ | |||
| Added documentations for :func:`fabs`, to take only integer input values. | |||
There was a problem hiding this comment.
shouldn't this say "added documentation for func factorial to indicate that returns integer values" ?
There was a problem hiding this comment.
Noted will do
There was a problem hiding this comment.
@mcscope you can check again
| @@ -0,0 +1 @@ | |||
| Added documentation for func factorial to indicate that returns integer values | |||
There was a problem hiding this comment.
Do we really need a NEWS entry for adding 3 words to the doc? I don't think so.
|
@akshaysharma096: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@akshaysharma096: Status check is done, and it's a failure ❌ . |
|
@akshaysharma096: Status check is done, and it's a failure ❌ . |
|
@akshaysharma096, thank you for the contribution. It has now been merged! 🎉 |
|
Thanks @akshaysharma096 for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…honGH-6420) (cherry picked from commit 4612671) Co-authored-by: Akshay Sharma <[email protected]>
|
GH-13702 is a backport of this pull request to the 3.7 branch. |
…6420) (cherry picked from commit 4612671) Co-authored-by: Akshay Sharma <[email protected]>
Issue link: math.factorial doc should mention integer return type
https://bugs.python.org/issue25735