bpo-33348: parse expressions after * and ** in lib2to3 #6586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping for review... @pablogsal ? |
|
Any update on this issue? |
|
closing and opening to re-trigger CI testing. |
gpshead
approved these changes
Oct 24, 2019
|
@zsol: Status check is done, and it's a success ✅ . |
|
Thanks @zsol for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8. |
|
GH-16913 is a backport of this pull request to the 3.8 branch. |
|
GH-16914 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @zsol, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2019
These are valid even in python 2.7 https://bugs.python.org/issue33348 Automerge-Triggered-By: @gpshead (cherry picked from commit 96b06ae) Co-authored-by: Zsolt Dollenstein <[email protected]>
|
If anyone wants to see this in lib2to3 included with the final 2.7.18 release of 2.7, they'l need to do the backport PR work. I suggest not worrying about it. :) |
miss-islington
added a commit
that referenced
this pull request
Oct 24, 2019
These are valid even in python 2.7 https://bugs.python.org/issue33348 Automerge-Triggered-By: @gpshead (cherry picked from commit 96b06ae) Co-authored-by: Zsolt Dollenstein <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 24, 2019
These are valid even in python 2.7 https://bugs.python.org/issue33348 Automerge-Triggered-By: @gpshead (cherry picked from commit 96b06ae) Co-authored-by: Zsolt Dollenstein <[email protected]>
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
These are valid even in python 2.7 https://bugs.python.org/issue33348 Automerge-Triggered-By: @gpshead
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
These are valid even in python 2.7 https://bugs.python.org/issue33348 Automerge-Triggered-By: @gpshead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are valid even in python 2.7
https://bugs.python.org/issue33348
Automerge-Triggered-By: @gpshead