Skip to content

bpo-20104: Remove posix_spawn from 3.7 #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2018

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 14, 2018

@pablogsal pablogsal changed the title bpo-20104: Remove posix_spawn in 3.7 bpo-20104: Remove posix_spawn from 3.7 May 14, 2018
@pablogsal pablogsal force-pushed the remove_posix_spawn branch 2 times, most recently from 3284174 to c200683 Compare May 14, 2018 15:10
@pablogsal
Copy link
Member Author

CC: @gpshead

@pablogsal pablogsal force-pushed the remove_posix_spawn branch from c200683 to a65ef05 Compare May 14, 2018 16:01
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks straight forward.

I suggest dropping the changes to aclocal.m4, configure.ac, configure, pyconfig.h.in that remove the check for the API. It is fine for us to leave the autoconf script in 3.7 testing for the posix_spawn function.

@gpshead
Copy link
Member

gpshead commented May 14, 2018

@ned-deily - what would you like to see for a Misc/NEWS.d entry for this. os.posix_spawn appeared in some betas but we're removing it before rc1. document it as being removed again? or just remove all prior mentions of adding it?

@gpshead gpshead self-assigned this May 14, 2018
@gpshead
Copy link
Member

gpshead commented May 14, 2018

err, wrong autocompleted. ned. sorry. :) @ned-deily :)

@gpshead gpshead requested a review from ned-deily May 14, 2018 16:23
gpshead added 2 commits May 14, 2018 11:35
and reference the removal from the old news entry where it was added.
We can keep the configure test for posix_spawn, we'll need it in the
future and having it in pyconfig.h will be convenient in case any
3.7 extension module wants to use it.
@gpshead
Copy link
Member

gpshead commented May 14, 2018

okay, i've undone the configure changes and done the news entries. just waiting for the various CI runs to complete (overloaded by the sprints) before merging.

@gpshead gpshead removed the request for review from ned-deily May 14, 2018 18:48
@gpshead gpshead merged commit 8e633a4 into python:3.7 May 14, 2018
@pablogsal pablogsal deleted the remove_posix_spawn branch May 14, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants