-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-20104: Remove posix_spawn from 3.7 #6794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3284174
to
c200683
Compare
CC: @gpshead |
c200683
to
a65ef05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks straight forward.
I suggest dropping the changes to aclocal.m4, configure.ac, configure, pyconfig.h.in that remove the check for the API. It is fine for us to leave the autoconf script in 3.7 testing for the posix_spawn function.
@ned-deily - what would you like to see for a Misc/NEWS.d entry for this. os.posix_spawn appeared in some betas but we're removing it before rc1. document it as being removed again? or just remove all prior mentions of adding it? |
err, wrong autocompleted. ned. sorry. :) @ned-deily :) |
and reference the removal from the old news entry where it was added.
We can keep the configure test for posix_spawn, we'll need it in the future and having it in pyconfig.h will be convenient in case any 3.7 extension module wants to use it.
okay, i've undone the configure changes and done the news entries. just waiting for the various CI runs to complete (overloaded by the sprints) before merging. |
https://bugs.python.org/issue20104