Skip to content

bpo-33502: dataclass._Dataclassparams repr: use repr of each member. #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Lib/dataclasses.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,12 @@ def __init__(self, init, repr, eq, order, unsafe_hash, frozen):

def __repr__(self):
return ('_DataclassParams('
f'init={self.init},'
f'repr={self.repr},'
f'eq={self.eq},'
f'order={self.order},'
f'unsafe_hash={self.unsafe_hash},'
f'frozen={self.frozen}'
f'init={self.init!r},'
f'repr={self.repr!r},'
f'eq={self.eq!r},'
f'order={self.order!r},'
f'unsafe_hash={self.unsafe_hash!r},'
f'frozen={self.frozen!r}'
')')


Expand Down
12 changes: 12 additions & 0 deletions f.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
from __future__ import annotations
from dataclasses import dataclass
from typing import List
from typing import ClassVar as CV

@dataclass
class A:
a: List[str]

@dataclass
class B(A):
b: CV[int]
15 changes: 15 additions & 0 deletions j.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@

class X:
def __init__(self, value):
self.value = value
def __str__(self):
return str(self.value)
def __format__(self, fmt):
assert fmt[0] == '='
self.value = eval(fmt[1:])
return ''

x = X(3)
print(x)
f'{x:=4}' # Behold!
print(x)
20 changes: 20 additions & 0 deletions t.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
from dataclasses import *

class D:
"""A descriptor class that knows its name."""
def __set_name__(self, owner, name):
self.name = name
def __get__(self, instance, owner):
if instance is not None:
return 1
return self

from dataclasses import *

@dataclass
class C:
d: int = field(default=D(), init=False)

@dataclass
class E(C):
e: int = field(default=D(), init=False)
31 changes: 31 additions & 0 deletions x.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#from __future__ import annotations
from typing import ClassVar, Dict, get_type_hints
from dataclasses import *

class Starship:
stats: ClassVar[Dict[str, int]] = {}

#print(get_type_hints(Starship))

#class A:
# a: Dict[int, C]

#print(get_type_hints(A))

cv = [ClassVar[int]]

@dataclass
class C:
CVS = [ClassVar[str]]
a: cv[0]
b: 'C'
c: 'CVS[0]'
x: 'ClassVar["int"]'
y: 'ClassVar[C]'

print()
print(C.__annotations__)
print(C.__dataclass_fields__)


#print(get_type_hints(C))