-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-33479: Remove unqualified tkinter threadsafe claim. #6990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should make this change now, and further consider additional clarification as per the discussion on the issue.
Serhiy, unless you object, I plan to merge this in a day or two after the tests pass. |
The true is that |
Requesting a review from Steve Dower was an accident. I was going to ask him about removing the failing VSTS tests but then discovered that they no longer matter. |
The tkinter thread code for threaded tcl works. The code for non-threaded tcl does not. See bpo-33257. I strongly feel that we should stop deceiving users with the latter into wasting time making futile attempts destined to fail. As my initial comment implies, this stripped down PR was only intended to be a minimal stop-gap, pending agreement on a replacement. My initial post on the bpo issue proposes a proposed replacement sentence and a new section for the tkinter doc that say the minimum that I think users should know, including how to identify which tcl build they have. I would prefer to include the full proposal in this PR. If you approve of it, or are at least willing to discuss it, I will add it. |
I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
@terryjreedy Could I merge this one? Thank you |
It has not been true for several years and likely never was. An explanation of what is true may be added later, after discussion, and possible after patching, but not before the coming 3.7.0rc1 release.
Thanks @terryjreedy for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
It has not been true for several years and likely never was. (cherry picked from commit 6b37d0d) Co-authored-by: Terry Jan Reedy <[email protected]>
GH-27704 is a backport of this pull request to the 3.10 branch. |
It has not been true for several years and likely never was. (cherry picked from commit 6b37d0d) Co-authored-by: Terry Jan Reedy <[email protected]>
GH-27705 is a backport of this pull request to the 3.9 branch. |
It has not been true for several years and likely never was. (cherry picked from commit 6b37d0d) Co-authored-by: Terry Jan Reedy <[email protected]>
…-27705) It has not been true for several years and likely never was. (cherry picked from commit 6b37d0d) Co-authored-by: Terry Jan Reedy <[email protected]>
It has not been true for several years and likely never was.
An explanation of what is true may be added later, after discussion,
and possibly after patching, but not before the coming 3.7.0rc1 release.
https://bugs.python.org/issue33479