Skip to content

bpo-33479: Remove unqualified tkinter threadsafe claim. #6990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented May 19, 2018

It has not been true for several years and likely never was.
An explanation of what is true may be added later, after discussion,
and possibly after patching, but not before the coming 3.7.0rc1 release.

https://bugs.python.org/issue33479

Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should make this change now, and further consider additional clarification as per the discussion on the issue.

@terryjreedy
Copy link
Member Author

Serhiy, unless you object, I plan to merge this in a day or two after the tests pass.
The outputs for VSTS: Linux and Windows just say "X Build not found"

@terryjreedy terryjreedy reopened this Oct 27, 2018
@terryjreedy terryjreedy requested a review from zooba October 27, 2018 02:32
@serhiy-storchaka
Copy link
Member

The true is that _tkinter provides a threadsafe mechanism which allows Python and Tcl to interact. Its code could be simpler without it. If it doesn't always work, this can be classified as a bug and should be fixed. The fact that Python contains bugs should not mean that we should remove any claims about intended behavior.

@terryjreedy terryjreedy removed the request for review from zooba October 27, 2018 22:12
@terryjreedy
Copy link
Member Author

Requesting a review from Steve Dower was an accident. I was going to ask him about removing the failing VSTS tests but then discovered that they no longer matter.

@terryjreedy
Copy link
Member Author

terryjreedy commented Oct 27, 2018

The tkinter thread code for threaded tcl works. The code for non-threaded tcl does not. See bpo-33257. I strongly feel that we should stop deceiving users with the latter into wasting time making futile attempts destined to fail. As my initial comment implies, this stripped down PR was only intended to be a minimal stop-gap, pending agreement on a replacement.

My initial post on the bpo issue proposes a proposed replacement sentence and a new section for the tkinter doc that say the minimum that I think users should know, including how to identify which tcl build they have. I would prefer to include the full proposal in this PR. If you approve of it, or are at least willing to discuss it, I will add it.

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@matrixise
Copy link
Member

@terryjreedy Could I merge this one? Thank you

It has not been true for several years and likely never was.
An explanation of what is true may be added later, after discussion,
and possible after patching, but not before the coming 3.7.0rc1 release.
@ambv ambv merged commit 6b37d0d into python:main Aug 10, 2021
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2021
It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 10, 2021
@bedevere-bot
Copy link

GH-27704 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2021
It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 10, 2021
@bedevere-bot
Copy link

GH-27705 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Aug 10, 2021
It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <[email protected]>
ambv pushed a commit that referenced this pull request Aug 10, 2021
…-27705)

It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <[email protected]>
@terryjreedy terryjreedy deleted the not_threadsafe branch December 17, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants