Skip to content

bpo-31215: Add version changed notes for OpenSSL 1.1.0 compatibility #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

storymode7
Copy link
Contributor

@storymode7 storymode7 commented Jun 2, 2018

I added the version changed notes as suggested by @ncoghlan this issue.

Please review :)

https://bugs.python.org/issue31215

@csabella
Copy link
Contributor

csabella commented Jun 4, 2018

LGTM, based on @ncoghlan's request. Nick, please take a look when you have an opportunity.

@ncoghlan ncoghlan merged commit 9ef1b06 into python:master Jun 5, 2018
@ncoghlan
Copy link
Contributor

ncoghlan commented Jun 5, 2018

Thanks for the patch, @storymode7!

And thanks @csabella for the nudge :)

@storymode7
Copy link
Contributor Author

Hey, sorry for bothering you again, but shouldn't this be backported to 3.7 and 3.6? Also, in the issue you suggested a different place for version changed note in 2.7 branch. So, I hope it's alright to submit another PR for the same issue number. Correct me if I am wrong :)

Here's the link for reference:
https://bugs.python.org/issue31215

@miss-islington
Copy link
Contributor

Thanks @storymode7 for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @storymode7 for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7525 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
@bedevere-bot
Copy link

GH-7526 is a backport of this pull request to the 3.7 branch.

@ncoghlan
Copy link
Contributor

ncoghlan commented Jun 8, 2018

@storymode7 Indeed, I missed adding the backport labels - thanks for the reminder!

And yeah, if you want to address the 2.7 change as well, then a separate PR for the same issue is the way to do - the one thing to do in addition to submitting the PR against the 2.7 support branch is to also add a [2.7] before the issue number in the PR title (similar to the automatically created backport PRs for the 3.x branches).

miss-islington added a commit that referenced this pull request Jun 8, 2018
miss-islington added a commit that referenced this pull request Jun 8, 2018
@storymode7 storymode7 deleted the master-doc-fix branch June 8, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants