-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-31215: Add version changed notes for OpenSSL 1.1.0 compatibility #7346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, based on @ncoghlan's request. Nick, please take a look when you have an opportunity. |
Thanks for the patch, @storymode7! And thanks @csabella for the nudge :) |
Hey, sorry for bothering you again, but shouldn't this be backported to 3.7 and 3.6? Also, in the issue you suggested a different place for version changed note in 2.7 branch. So, I hope it's alright to submit another PR for the same issue number. Correct me if I am wrong :) Here's the link for reference: |
Thanks @storymode7 for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Thanks @storymode7 for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-7525 is a backport of this pull request to the 3.6 branch. |
…ythonGH-7346) (cherry picked from commit 9ef1b06) Co-authored-by: Mayank Singhal <[email protected]>
…ythonGH-7346) (cherry picked from commit 9ef1b06) Co-authored-by: Mayank Singhal <[email protected]>
GH-7526 is a backport of this pull request to the 3.7 branch. |
@storymode7 Indeed, I missed adding the backport labels - thanks for the reminder! And yeah, if you want to address the 2.7 change as well, then a separate PR for the same issue is the way to do - the one thing to do in addition to submitting the PR against the 2.7 support branch is to also add a |
…H-7346) (cherry picked from commit 9ef1b06) Co-authored-by: Mayank Singhal <[email protected]>
…H-7346) (cherry picked from commit 9ef1b06) Co-authored-by: Mayank Singhal <[email protected]>
I added the version changed notes as suggested by @ncoghlan this issue.
Please review :)
https://bugs.python.org/issue31215