Skip to content

bpo-33752: Fix a file leak in test_dbm. #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2018
Merged

bpo-33752: Fix a file leak in test_dbm. #7376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d24a18
bpo-33752: Fix a file leak in test_dbm.
serhiy-storchaka Jun 4, 2018
614b5f8
Use 'with'.
serhiy-storchaka Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Lib/test/test_dbm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,8 @@ def test_anydbm_creation(self):
def test_anydbm_creation_n_file_exists_with_invalid_contents(self):
# create an empty file
test.support.create_empty_file(_fname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the empty line. IMHO it helps for the readability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is short (just 4 lines), and no other test method contains an empty line inside. Having an empty line that splits this short test rather adds a false signal that attract an attention to an insignificant detail.

But if you still think that it is worth to restore an empty line, I'll do this.


f = dbm.open(_fname, 'n')
self.addCleanup(f.close)
self.assertEqual(len(f), 0)
with dbm.open(_fname, 'n') as f:
self.assertEqual(len(f), 0)

def test_anydbm_modification(self):
self.init_db()
Expand Down