bpo-33751: Fix test_file. #7378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testModeStrings and testTruncateOnWindows were depended on a file leaked in other tests. Also improve cleaning up after tests.
serhiy-storchaka
added
needs backport to 3.6
tests
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 5, 2018
testModeStrings and testTruncateOnWindows were depended on a file leaked in other tests. Also improve cleaning up after tests. (cherry picked from commit c2745d2) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-7435 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-7436 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 5, 2018
testModeStrings and testTruncateOnWindows were depended on a file leaked in other tests. Also improve cleaning up after tests. (cherry picked from commit c2745d2) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 5, 2018
testModeStrings and testTruncateOnWindows were depended on a file leaked in other tests. Also improve cleaning up after tests. (cherry picked from commit c2745d2) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 5, 2018
testModeStrings and testTruncateOnWindows were depended on a file leaked in other tests. Also improve cleaning up after tests. (cherry picked from commit c2745d2) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-7445 is a backport of this pull request to the 2.7 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 6, 2018
testModeStrings and testTruncateOnWindows were depended on a file leaked in other tests. Also improve cleaning up after tests.. (cherry picked from commit c2745d2) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testModeStrings and testTruncateOnWindows were depended on
a file leaked in other tests.
Also improve cleaning up after tests.
https://bugs.python.org/issue33751