bpo-29204: Emit warnings for already deprecated ElementTree features. #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Element.getiterator() and the html parameter of XMLParser() were deprecated only in the documentation. Now using them emits a deprecation warning.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @eliben and @florentx to be potential reviewers. |
vadmium
reviewed
Mar 23, 2017
Lib/test/test_xml_etree_c.py
Outdated
| @@ -1,14 +1,15 @@ | |||
| # xml.etree test for cElementTree | |||
| import struct | |||
| from test import support | |||
| from test.support import import_fresh_module | |||
| from test.support import import_fresh_module, check_warnings | |||
There was a problem hiding this comment.
Probably don’t need check_warnings any more
Carreau
added a commit
to Carreau/cpython
that referenced
this pull request
May 11, 2018
Warning were added in pythongh-773, but did not contain version since deprecation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element.getiterator()and thehtmlparameter ofXMLParser()weredeprecated only in the documentation. Now using them emits a deprecation
warning.