Skip to content

bpo-33663: Convert content length to string before putting to header #7754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2018
Merged

bpo-33663: Convert content length to string before putting to header #7754

merged 2 commits into from
Jun 18, 2018

Conversation

ValeriyaSinevich
Copy link
Contributor

@ValeriyaSinevich ValeriyaSinevich commented Jun 16, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@ValeriyaSinevich
Copy link
Contributor Author

CLA agreement is signed.

@zooba
Copy link
Member

zooba commented Jun 18, 2018 •
edited
Loading

Looks good, thanks!

@zooba zooba merged commit b36b0a3 into python:master Jun 18, 2018
@miss-islington
Copy link
Contributor

Thanks @ValeriyaSinevich for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7781 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2018
@ValeriyaSinevich @miss-islington
bpo-33663: Convert content length to string before putting to header (p…
39bddeb 
…ythonGH-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
@bedevere-bot
Copy link

GH-7782 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2018
@ValeriyaSinevich @miss-islington
bpo-33663: Convert content length to string before putting to header (p…
f7911bc 
…ythonGH-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
miss-islington added a commit that referenced this pull request Jun 18, 2018
@miss-islington @ValeriyaSinevich
bpo-33663: Convert content length to string before putting to header (G…
53d1e9f 
…H-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
miss-islington added a commit that referenced this pull request Jun 18, 2018
@miss-islington @ValeriyaSinevich
bpo-33663: Convert content length to string before putting to header (G…
8c19a44 
…H-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
@rayluo
Copy link

rayluo commented Jun 22, 2018

PR looks good! Off topic: why that bot duplicated the url in the PR description? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ValeriyaSinevich @the-knights-who-say-ni @zooba @miss-islington @bedevere-bot @rayluo