bpo-29884: faulthandler: Restore the old sigaltstack during teardown #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tich, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @serhiy-storchaka and @benjaminp to be potential reviewers. |
vstinner
requested changes
Mar 23, 2017
|
And tests. |
IMHO it's overkill to test this bugfix. It's a corner case which requires to write a program which embeds Python and uses sigaltstack(). |
|
Added myself to ACKS and listed the fix in NEWS. Thanks! |
Misc/NEWS
Outdated
| @@ -775,6 +775,9 @@ Library | |||
| - Issue #29581: ABCMeta.__new__ now accepts **kwargs, allowing abstract base | |||
| classes to use keyword parameters in __init_subclass__. Patch by Nate Soares. | |||
|
|
|||
| - Issue #29884: faulthandler: Restore the old sigaltstack during teardown. | |||
There was a problem hiding this comment.
Move it to the start of the Library section.
Okay, then tests are not required. |
vstinner
approved these changes
Mar 23, 2017
|
Thanks! I merged your fix. It would be nice to backport the fix Python 3.5 & 3.6 (using git cherry-pick). |
tich
added a commit
to tich/cpython
that referenced
this pull request
Mar 24, 2017
(cherry picked from commit 20fbf8a)
tich
added a commit
to tich/cpython
that referenced
this pull request
Mar 24, 2017
(cherry picked from commit 20fbf8a)
Mariatta
pushed a commit
that referenced
this pull request
Mar 24, 2017
Mariatta
pushed a commit
that referenced
this pull request
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.