bpo-33921: Clarify how to bind to all interfaces using socket #7877
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again for your contribution, we look forward to reviewing it! |
|
Updated b.p.o account to associate GitHub username. |
Doc/library/socket.rst
Outdated
| @@ -69,6 +69,13 @@ created. Socket addresses are represented as follows: | |||
| where *host* is a string representing either a hostname in Internet domain | |||
| notation like ``'daring.cwi.nl'`` or an IPv4 address like ``'100.50.200.5'``, | |||
| and *port* is an integer. | |||
|
|
|||
| - For IPv4 addresses, two special forms are accepted instead of a host | |||
There was a problem hiding this comment.
You've got trailing whitespace on some of these lines, aside from that the content looks good.
|
Still one line left with trailing whitespace: https://travis-ci.org/python/cpython/jobs/395902432#L544 fyi, you can catch these locally before pushing by running |
|
@ammaraskar Thanks for the heads up. Been editing in the browser for this for simplicity, but I'll note that for next time if it's a more substantial PR. |
|
@ned-deily Are you available to review? |
|
Thanks @johnthagen for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
…GH-7877) Clarify how to bind to all interfaces using socket (cherry picked from commit 95dfb9c) Co-authored-by: johnthagen <[email protected]>
|
GH-8513 is a backport of this pull request to the 3.7 branch. |
…GH-7877) Clarify how to bind to all interfaces using socket (cherry picked from commit 95dfb9c) Co-authored-by: johnthagen <[email protected]>
|
GH-8514 is a backport of this pull request to the 3.6 branch. |
Clarify how to bind to all interfaces using socket (cherry picked from commit 95dfb9c) Co-authored-by: johnthagen <[email protected]>
Clarify how to bind to all interfaces using socket (cherry picked from commit 95dfb9c) Co-authored-by: johnthagen <[email protected]>
Fixes https://bugs.python.org/issue33921
https://bugs.python.org/issue33921