Skip to content

bpo-29862: Fixed grammar error in TypeError exception message in reload function #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2017

Conversation

mandeep
Copy link
Contributor

@mandeep mandeep commented Mar 24, 2017

Fixed the grammar error found by Brett in the TypeError exception message on Line 140. All tests passed after making the change so I went ahead and created this pull request. If I need to add a test that checks the exception message, please let me know.

@mention-bot
Copy link

@mandeep, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @ericsnowcurrently and @ncoghlan to be potential reviewers.

@Mariatta
Copy link
Member

Looks good :) Thanks, @mandeep 🎉

@Mariatta
Copy link
Member

@mandeep Could you add a test for this change? Thanks :)

@orsenthil
Copy link
Member

@Mariatta , we only assert the Exception Type, and we don't test the contents of the Exception Str. So, the change LGTM as it is.

@Mariatta
Copy link
Member

Ah ok, Thanks @orsenthil :) I thought we needed to get codecov green by adding test. In that case I can merge this. Still wondering whether this needs to be backported at all?

@orsenthil
Copy link
Member

Since it is a grammar / spell fix, backporting seems harmless to me. +1 if you were planning to do that.

@Mariatta Mariatta merged commit 9f0aa48 into python:master Mar 25, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 25, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 25, 2017
@mandeep
Copy link
Contributor Author

mandeep commented Mar 25, 2017

@Mariatta sorry I couldn't respond sooner. Thanks for submitting the backport changes. 😃

Mariatta added a commit that referenced this pull request Mar 25, 2017
Mariatta added a commit that referenced this pull request Mar 25, 2017
@Mariatta
Copy link
Member

Thanks again @orsenthil and @mandeep :)
This has been backported into 3.5 and 3.6, and I closed the b.p.o issue. 🎉

@mandeep mandeep deleted the fix-issue-29862 branch March 25, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants