Skip to content

bpo-32523: Simplifying news entries with multiple paragraphs. #8154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2019
+38 −123
Merged

bpo-32523: Simplifying news entries with multiple paragraphs. #8154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Misc/NEWS.d/3.5.0a2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ Lawrence.
.. section: Library
Corrected pure python implementation of timedelta division.

Eliminated OverflowError from ``timedelta * float`` for some floats;
Corrected rounding in timedelta true division.

Expand Down
1 change: 0 additions & 1 deletion Misc/NEWS.d/3.5.2rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,6 @@ Fixed the comparison of plistlib.Data with other types.
.. section: Library

Fix an uninitialized variable in `ctypes.util`.

The bug only occurs on SunOS when the ctypes implementation searches for the
`crle` program. Patch by Xiang Zhang. Tested on SunOS by Kees Bos.

Expand Down
1 change: 0 additions & 1 deletion Misc/NEWS.d/3.5.3rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,6 @@ command.
.. section: Library

Fixed calendar functions for extreme months: 0001-01 and 9999-12.

Methods itermonthdays() and itermonthdays2() are reimplemented so that they
don't call itermonthdates() which can cause datetime.date under/overflow.

Expand Down
4 changes: 0 additions & 4 deletions Misc/NEWS.d/3.5.4rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ by Nir Soffer.
.. section: Library

signal.setitimer() may disable the timer when passed a tiny value.

Tiny values (such as 1e-6) are valid non-zero values for setitimer(), which
is specified as taking microsecond-resolution intervals. However, on some
platform, our conversion routine could convert 1e-6 into a zero interval,
Expand Down Expand Up @@ -1001,15 +1000,12 @@ test_zipfile64.
.. section: Tests

regrtest: Enhance regrtest and backport features from the master branch.

Add options: --coverage, --testdir, --list-tests (list test files, don't run
them), --list-cases (list test identifiers, don't run them, :issue:`30523`),
--matchfile (load a list of test filters from a text file, :issue:`30540`),
--slowest (alias to --slow).

Enhance output: add timestamp, test result, currently running tests, "Tests
result: xxx" summary with total duration, etc.

Fix reference leak hunting in regrtest, --huntrleaks: regrtest now warms up
caches, create explicitly all internal singletons which are created on
demand to prevent false positives when checking for reference leaks.
Expand Down
10 changes: 4 additions & 6 deletions Misc/NEWS.d/3.5.5rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ by revealing an inconsistency in how sys.path is initialized when executing
considered a potential security issue, as it may lead to privileged
processes unexpectedly loading code from user controlled directories in
situations where that was not previously the case.

The interpreter now consistently avoids ever adding the import location's
parent directory to ``sys.path``, and ensures no other ``sys.path`` entries
are inadvertently modified when inserting the import location named on the
Expand Down Expand Up @@ -56,11 +55,10 @@ Fix potential crash during GC caused by ``tp_dealloc`` which doesn't call
.. section: Library

Fixed issues with binary plists:

* Fixed saving bytearrays.
* Identical objects will be saved only once.
* Equal references will be load as identical objects.
* Added support for saving and loading recursive data structures.
Fixed saving bytearrays.
Identical objects will be saved only once.
Equal references will be load as identical objects.
Added support for saving and loading recursive data structures.

..

Expand Down
1 change: 0 additions & 1 deletion Misc/NEWS.d/3.6.0a1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,6 @@ Fixed the comparison of plistlib.Data with other types.
.. section: Library

Fix an uninitialized variable in `ctypes.util`.

The bug only occurs on SunOS when the ctypes implementation searches for the
`crle` program. Patch by Xiang Zhang. Tested on SunOS by Kees Bos.

Expand Down
2 changes: 0 additions & 2 deletions Misc/NEWS.d/3.6.0b2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,6 @@ xml.etree.ElementTree.Element.
.. section: Library
Stop using localtime() and gmtime() in the time module.

Introduced platform independent _PyTime_localtime API that is similar to
POSIX localtime_r, but available on all platforms. Patch by Ed Schouten.

Expand All @@ -390,7 +389,6 @@ POSIX localtime_r, but available on all platforms. Patch by Ed Schouten.
.. section: Library
Fixed calendar functions for extreme months: 0001-01 and 9999-12.

Methods itermonthdays() and itermonthdays2() are reimplemented so that they
don't call itermonthdates() which can cause datetime.date under/overflow.

Expand Down
1 change: 0 additions & 1 deletion Misc/NEWS.d/3.6.2rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,6 @@ the link targets for :func:`bytes` and :func:`bytearray` are now their
respective type definitions, rather than the corresponding builtin function
entries. Use :ref:`bytes <func-bytes>` and :ref:`bytearray <func-bytearray>`
to reference the latter.

In order to ensure this and future cross-reference updates are applied
automatically, the daily documentation builds now disable the default output
caching features in Sphinx.
Expand Down
22 changes: 3 additions & 19 deletions Misc/NEWS.d/3.6.3rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ ImportError rather than SystemError.
.. section: Core and Builtins
Improve signal delivery.

Avoid using Py_AddPendingCall from signal handler, to avoid calling
signal-unsafe functions. The tests I'm adding here fail without the rest of
the patch, on Linux and OS X. This means our signal delivery logic had
Expand Down Expand Up @@ -596,7 +595,6 @@ Fix out of bounds write in `asyncio.CFuture.remove_done_callback()`.
.. section: Library
signal.setitimer() may disable the timer when passed a tiny value.

Tiny values (such as 1e-6) are valid non-zero values for setitimer(), which
is specified as taking microsecond-resolution intervals. However, on some
platform, our conversion routine could convert 1e-6 into a zero interval,
Expand Down Expand Up @@ -774,7 +772,6 @@ Add a missing xmlns to python.manifest so that it matches the schema.
.. section: IDLE
IDLE code context -- fix code update and font update timers.

Canceling timers prevents a warning message when test_idle completes.

..
Expand Down Expand Up @@ -817,7 +814,6 @@ IDLE - make tests pass with zzdummy extension disabled by default.
Document how IDLE runs tkinter programs. IDLE calls tcl/tk update in the
background in order to make live

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra line was an error.

interaction and experimentation with tkinter applications much easier.

..
Expand Down Expand Up @@ -847,7 +843,6 @@ Rearrange IDLE configdialog GenPage into Window, Editor, and Help sections.
.. section: IDLE
IDLE - Add docstrings and tests for outwin subclass of editor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With hg, news items were expected to be the same as commit messages, and commit messages were expected to have a blank line after the title/subject line. This is still recommended for git commit messages, but apparently is handled for us in github by having separate title and message boxes when doing the squash merge commit.

I initially continued adding blank lines because I noticed that without them the message was re-wrapped so that there was no separate subject line, contrary to how news entries were once expected to look. Once I learned that NEWS entries were now supposed to be a single paragraph without a separate header, I stopped the blanks.

Move some data and functions from the class to module level. Patch by Cheryl
Sabella.

Expand All @@ -868,24 +863,20 @@ IDLE - Do not modify tkinter.message in test_configdialog.
.. section: IDLE
Convert IDLE's built-in 'extensions' to regular features.

About 10 IDLE features were implemented as supposedly optional extensions.
Their different behavior could be confusing or worse for users and not good
for maintenance. Hence the conversion.

The main difference for users is that user configurable key bindings for
builtin features are now handled uniformly. Now, editing a binding in a
keyset only affects its value in the keyset. All bindings are defined
together in the system-specific default keysets in config-extensions.def.
All custom keysets are saved as a whole in config-extension.cfg. All take
effect as soon as one clicks Apply or Ok.

The affected events are '<<force-open-completions>>', '<<expand-word>>',
'<<force-open-calltip>>', '<<flash-paren>>', '<<format-paragraph>>',
'<<run-module>>', '<<check-module>>', and '<<zoom-height>>'. Any (global)
customizations made before 3.6.3 will not affect their keyset-specific
customization after 3.6.3. and vice versa.

Inital patch by Charles Wohlganger.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Ned complained about a long IDLE news message for 3.7.0b5 or .0rc1, I started putting the long form message I think current users really need to see, like the above, in idlelib/NEWS.txt, viewed on About IDLE, and a condensed form in the general news entry. I also am adding more IDLE entries in What's New, including some x.y.z entries.

Putting acknowledgements on a new line, sometimes separated by a blank, was also standard practice. I mostly did not insert a blank except in a case like this. I see that others often did.


..
Expand Down Expand Up @@ -974,7 +965,6 @@ continue to pass. Patch by Cheryl Sabella.
.. section: IDLE
IDLE - Factor FontPage(Frame) class from ConfigDialog.

Slightly modified tests continue to pass. Fix General tests. Patch mostly by
Cheryl Sabella.

Expand Down Expand Up @@ -1007,7 +997,6 @@ the tabs and will enable splitting the groups into classes.
.. section: IDLE
IDLE -- Factor a VarTrace class out of ConfigDialog.

Instance tracers manages pairs consisting of a tk variable and a callback
function. When tracing is turned on, setting the variable calls the
function. Test coverage for the new class is 100%.
Expand All @@ -1029,12 +1018,10 @@ IDLE: Add more tests for General tab.
.. section: IDLE
IDLE - Improve configdialog font page and tests.

In configdialog: Document causal pathways in create_font_tab docstring.
Simplify some attribute names. Move set_samples calls to var_changed_font
(idea from Cheryl Sabella). Move related functions to positions after the
create widgets function.

In test_configdialog: Fix test_font_set so not order dependent. Fix renamed
test_indent_scale so it tests the widget. Adjust tests for movement of
set_samples call. Add tests for load functions. Put all font tests in one
Expand Down Expand Up @@ -1077,12 +1064,9 @@ Patch by Louie Lu.
.. section: IDLE
Document coverage details for idlelib tests.

* Add section to idlelib/idle-test/README.txt.

* Include check that branches are taken both ways.

* Exclude IDLE-specific code that does not run during unit tests.
Add section to idlelib/idle-test/README.txt.
Include check that branches are taken both ways.
Exclude IDLE-specific code that does not run during unit tests.

..
Expand Down
36 changes: 13 additions & 23 deletions Misc/NEWS.d/3.6.4rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,13 @@ function.
.. section: Core and Builtins

Fixed several issues in printing tracebacks (PyTraceBack_Print()).

* Setting sys.tracebacklimit to 0 or less now suppresses printing tracebacks.
* Setting sys.tracebacklimit to None now causes using the default limit.
* Setting sys.tracebacklimit to an integer larger than LONG_MAX now means using
the limit LONG_MAX rather than the default limit.
* Fixed integer overflows in the case of more than 2**31 traceback items on
Windows.
* Fixed output errors handling.
Setting sys.tracebacklimit to 0 or less now suppresses printing tracebacks.
Setting sys.tracebacklimit to None now causes using the default limit.
Setting sys.tracebacklimit to an integer larger than LONG_MAX now means using
the limit LONG_MAX rather than the default limit.
Fixed integer overflows in the case of more than 2**31 traceback items on
Windows.
Fixed output errors handling.

..

Expand Down Expand Up @@ -308,7 +307,6 @@ value of property is ``VT_EMPTY``. Initial patch by Mark Mc Mahon.
Fix wrong usage of :func:`collections.namedtuple` in the
:meth:`RobotFileParser.parse() <urllib.robotparser.RobotFileParser.parse>`
method.

Initial patch by Robin Wellner.

..
Expand Down Expand Up @@ -340,11 +338,10 @@ characters/bytes for non-negative *n*. This makes it compatible with
.. section: Library

Fixed issues with binary plists:

* Fixed saving bytearrays.
* Identical objects will be saved only once.
* Equal references will be load as identical objects.
* Added support for saving and loading recursive data structures.
Fixed saving bytearrays.
Identical objects will be saved only once.
Equal references will be load as identical objects.
Added support for saving and loading recursive data structures.

..

Expand Down Expand Up @@ -392,10 +389,8 @@ Reduce performance overhead of asyncio debug mode.
.. section: Library

Fixed determining the MAC address in the uuid module:

* Using ifconfig on NetBSD and OpenBSD.
* Using arp on Linux, FreeBSD, NetBSD and OpenBSD.

Using ifconfig on NetBSD and OpenBSD.
Using arp on Linux, FreeBSD, NetBSD and OpenBSD.
Based on patch by Takayuki Shimizukawa.

..
Expand Down Expand Up @@ -913,7 +908,6 @@ Avoid wholesale rebuild after `make regen-all` if nothing changed.

Return ``None`` when ``View.Fetch()`` returns ``ERROR_NO_MORE_ITEMS``
instead of raising ``MSIError``.

Initial patch by Anthony Tuininga.

..
Expand Down Expand Up @@ -997,7 +991,6 @@ persist while IDLE remains open
.. section: IDLE

Test_code_module now passes if run after test_idle, which sets ps1.

The code module uses sys.ps1 if present or sets it to '>>> ' if not.
Test_code_module now properly tests both behaviors. Ditto for ps2.

Expand Down Expand Up @@ -1034,7 +1027,6 @@ a bit about the additions.
.. section: IDLE

Simplify the API of IDLE's Module Browser.

Passing a widget instead of an flist with a root widget opens the option of
creating a browser frame that is only part of a window. Passing a full file
name instead of pieces assumed to come from a .py file opens the possibility
Expand Down Expand Up @@ -1099,10 +1091,8 @@ for code and tests by Guilherme Polo and Cheryl Sabella, respectively.
.. section: Tools/Demos

Make redemo work with Python 3.6 and newer versions.

Also, remove the ``LOCALE`` option since it doesn't work with string
patterns in Python 3.

Patch by Christoph Sarnowski.

..
Expand Down
1 change: 0 additions & 1 deletion Misc/NEWS.d/3.6.5rc1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,6 @@ locale to the ``LC_NUMERIC`` locale to decode ``decimal_point`` and
``thousands_sep`` byte strings if they are non-ASCII or longer than 1 byte,
and the ``LC_NUMERIC`` locale is different than the ``LC_CTYPE`` locale.
This temporary change affects other threads.

Same change for the :meth:`str.format` method when formatting a number
(:class:`int`, :class:`float`, :class:`float` and subclasses) with the ``n``
type (ex: ``'{:n}'.format(1234)``).
Expand Down
Loading