Skip to content

bpo-19791: Use functions from test support to check the symlink support. #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2017
Merged

bpo-19791: Use functions from test support to check the symlink support. #822

merged 1 commit into from
Mar 28, 2017

Conversation

vajrasky
Copy link
Contributor

We have functions to check the symlink support already. No need to reinvent the wheel. On top of that, can_symlink() is clearer than not symlink_skip_reason.

@mention-bot
Copy link

@vajrasky, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @zooba and @warsaw to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@vajrasky
Copy link
Contributor Author

Oh yeah, I have signed the CLA a long time ago. I just forgot to put my github name in the detail.

@serhiy-storchaka serhiy-storchaka changed the title [Finished #19791] Use functions from test support to check the symlink support. bpo-19791: Use functions from test support to check the symlink support. Mar 26, 2017
@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement tests Tests in the Lib/test dir labels Mar 26, 2017
@serhiy-storchaka serhiy-storchaka requested a review from pitrou March 26, 2017 13:57
brettcannon
brettcannon requested changes Mar 27, 2017
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue with how the names are referenced, otherwise LGTM!

Lib/test/test_pathlib.py Outdated
@@ -11,7 +11,7 @@

from test import support
android_not_root = support.android_not_root
TESTFN = support.TESTFN
from test.support import (can_symlink, skip_unless_symlink, TESTFN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.support is already imported as support, so please just access the attributes off of that instead of importing them directly.

And FYI, the parentheses are unnecessary.

@brettcannon brettcannon merged commit ec1f5df into python:master Mar 28, 2017
@brettcannon
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vajrasky @mention-bot @the-knights-who-say-ni @brettcannon @serhiy-storchaka