Skip to content

bpo-29162: IDLE: import sys before we use it on line 9 #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2017
Merged

bpo-29162: IDLE: import sys before we use it on line 9 #828

merged 1 commit into from
Mar 27, 2017

Conversation

JelleZijlstra
Copy link
Member

No description provided.

@mention-bot
Copy link

@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @ned-deily to be potential reviewers.

@Mariatta Mariatta added the type-bug An unexpected behavior, bug, or error label Mar 26, 2017
@terryjreedy terryjreedy self-assigned this Mar 27, 2017
@terryjreedy
Copy link
Member

Thank you both for the catch and review. This is a continuation of bpo-29162 (correct spelling?) and its incomplete fix. This time, there is no substitute for moving the import of sys.

Can either of you modify the title appropriately, so this will (maybe) get linked to the issue? I have not yet gotten up to speed with git and github. I will then hit [Squash and merge].

3.6 is the only backport needed, and no revision will be needed.

@Mariatta Mariatta changed the title IDLE: import sys before we use it on line 9 bpo-29162: IDLE: import sys before we use it on line 9 Mar 27, 2017
@terryjreedy terryjreedy merged commit 0579e81 into python:master Mar 27, 2017
@terryjreedy
Copy link
Member

Can one of you do the backport/cherry-pick?

@Mariatta
Copy link
Member

Thanks for the merge, @terryjreedy :) I'll backport this to 3.6

@JelleZijlstra JelleZijlstra deleted the patch-6 branch March 27, 2017 02:23
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 27, 2017
@JelleZijlstra @Mariatta
import sys before we use it on line 9 (python#828)
53815ef 
(cherry picked from commit 0579e81)
@Mariatta
Copy link
Member

backport PR at GH-828

Mariatta added a commit that referenced this pull request Mar 27, 2017
@Mariatta
import sys before we use it on line 9 (GH-828) (GH-833)
d2fc782 
(cherry picked from commit 0579e81)
@Mariatta
Copy link
Member

Wrong link earlier. Backport PR was at GH-833, and it's been merged to 3.6.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

@terryjreedy terryjreedy

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JelleZijlstra @mention-bot @terryjreedy @Mariatta @the-knights-who-say-ni