bpo-34141: Optimized pickling simple non-recursive values. #8318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Jul 17, 2018
| @@ -3952,7 +3949,7 @@ save(PicklerObject *self, PyObject *obj, int pers_save) | |||
| 1 if a persistent id was saved. | |||
| */ | |||
| if ((status = save_pers(self, obj)) != 0) | |||
There was a problem hiding this comment.
Can this trigger a recursive call?
There was a problem hiding this comment.
save_pers() calls save() with pers_save=1, and this stops the recursion via save_pers.
|
On the principle I like this. |
|
Thank you. Do you have to suggest any explanation comments? |
pitrou
reviewed
Jul 17, 2018
Modules/_pickle.c
Outdated
| } | ||
| else if (type == &PyDict_Type) { | ||
|
|
||
| if (Py_EnterRecursiveCall(" while pickling an object")) { |
There was a problem hiding this comment.
Perhaps add a comment such as """We're only calling Py_EnterRecursiveCall here so that atomic types above are pickled faster"""?
rhettinger
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34141