Skip to content

bpo-34144: Fix of venv acvtivate.bat for win 10 #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2019

Conversation

LorenzMende
Copy link
Contributor

@LorenzMende LorenzMende commented Jul 18, 2018

The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)

https://bugs.python.org/issue34144

The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)
@fvollmer
Copy link

Fix works for me (Windows 10 Pro German, Codepage 850)

@schlauch
Copy link

schlauch commented Sep 22, 2018

Any idea when this/such a fix is available and in which versions? I recently came across this on a Windows 7 system. It makes the usage of / getting started with virtual environments a little hard.

It tested the fix and it work.

@macetw
Copy link

macetw commented Oct 8, 2018

This fix also worked for me, when tested on the German platform.

@csabella csabella requested a review from zooba April 9, 2019 13:14
@csabella
Copy link
Contributor

csabella commented Apr 9, 2019

Requesting review from @zooba as he contributed the original change in bpo-32409. There are also comments under that commit from November 2018 referencing this same issue.

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can be merged once the NEWS entry is added.

@csabella
Copy link
Contributor

csabella commented Apr 9, 2019

@LorenzMende, please add a NEWS entry for this to be merged.

@zooba, thank you for the review.

@LorenzMende
Copy link
Contributor Author

thx @zooba for the review, I tried blurb_it for the NEWS entry - first time.
Let me know if something is incorrect.

@zooba
Copy link
Member

zooba commented Apr 10, 2019

I improved the text a little (these turn into actual documentation, so it's worth making them easily readable) and tagged this to automerge once the CI completes.

Thanks!

@miss-islington
Copy link
Contributor

@LorenzMende: Status check is done, and it's a success ✅ .

@0xLeon
Copy link

0xLeon commented May 21, 2019

Will this be backported to 3.7 (and maybe earlier) as well? Personally I'm only interested in 3.7, but maybe for the sake of full coverage, it could be ported back to earlier versions as well.

@miss-islington
Copy link
Contributor

Thanks @LorenzMende for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-13465 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2019
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)

https://bugs.python.org/issue34144
(cherry picked from commit 6955d44)

Co-authored-by: Lorenz Mende <[email protected]>
miss-islington added a commit that referenced this pull request May 21, 2019
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)

https://bugs.python.org/issue34144
(cherry picked from commit 6955d44)

Co-authored-by: Lorenz Mende <[email protected]>
@s-trooper
Copy link

will be that fixed for 3.6 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.