-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-34144: Fix of venv acvtivate.bat for win 10 #8321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)
Fix works for me (Windows 10 Pro German, Codepage 850) |
Any idea when this/such a fix is available and in which versions? I recently came across this on a Windows 7 system. It makes the usage of / getting started with virtual environments a little hard. It tested the fix and it work. |
This fix also worked for me, when tested on the German platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Can be merged once the NEWS entry is added.
@LorenzMende, please add a NEWS entry for this to be merged. @zooba, thank you for the review. |
thx @zooba for the review, I tried blurb_it for the NEWS entry - first time. |
I improved the text a little (these turn into actual documentation, so it's worth making them easily readable) and tagged this to automerge once the CI completes. Thanks! |
@LorenzMende: Status check is done, and it's a success ✅ . |
Will this be backported to 3.7 (and maybe earlier) as well? Personally I'm only interested in 3.7, but maybe for the sake of full coverage, it could be ported back to earlier versions as well. |
Thanks @LorenzMende for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-13465 is a backport of this pull request to the 3.7 branch. |
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot) https://bugs.python.org/issue34144 (cherry picked from commit 6955d44) Co-authored-by: Lorenz Mende <[email protected]>
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot) https://bugs.python.org/issue34144 (cherry picked from commit 6955d44) Co-authored-by: Lorenz Mende <[email protected]>
will be that fixed for 3.6 as well? |
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)
https://bugs.python.org/issue34144