Skip to content

[3.6] bpo-32692: Fix test_threading.test_set_and_clear() (GH-8331) #8340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 19, 2018

Increase the timeout: give timeout x 4 instead of timeout x 2 to
threads to wait until the Event is set, but reduce the sleep from 500
ms to 250 ms. So the test should be more reliable and faster!
(cherry picked from commit 8195049)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue32692

Increase the timeout: give timeout x 4 instead of timeout x 2 to
threads to wait until the Event is set, but reduce the sleep from 500
ms to 250 ms. So the test should be more reliable and faster!
(cherry picked from commit 8195049)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 2fe1c6b into python:3.6 Jul 19, 2018
@miss-islington miss-islington deleted the backport-8195049-3.6 branch July 19, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants