Skip to content

bpo-34136: Make test_do_not_recreate_annotations more reliable. #8364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2018
Merged

bpo-34136: Make test_do_not_recreate_annotations more reliable. #8364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Lib/test/test_opcodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Python test set -- part 2, opcodes

import unittest
from test import ann_module
from test import ann_module, support

class OpcodeTest(unittest.TestCase):

Expand Down Expand Up @@ -42,10 +42,14 @@ def test_use_existing_annotations(self):
self.assertEqual(ns['__annotations__'], {'x': int, 1: 2})

def test_do_not_recreate_annotations(self):
class C:
del __annotations__
with self.assertRaises(NameError):
x: int
annotations = {}
# Don't rely on the existence of the '__annotations__' global.
with support.swap_item(globals(), '__annotations__', annotations):
class C:
del __annotations__
x: int # Updates the '__annotations__' global.
self.assertIn('x', annotations)
self.assertIs(annotations['x'], int)

def test_raise_class_exceptions(self):

Expand Down