Skip to content

bpo-29924: Remove useless argument #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2017
Merged

bpo-29924: Remove useless argument #854

merged 1 commit into from
Mar 27, 2017

Conversation

SylvainDe
Copy link
Contributor

No description provided.

@mention-bot
Copy link

@SylvainDe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @methane and @serhiy-storchaka to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@SylvainDe
Copy link
Contributor Author

I've signed the CLA.

@SylvainDe
Copy link
Contributor Author

@Haypo may be the most relevant reviewer for this.

@vstinner
Copy link
Member

I've signed the CLA.

The change LGTM, but it seems like the signature wasn't validated yet. Let's wait 1 or 2 days and check again if the bot is happy.

Did you set your GitHub username in your bugs.python.org profile?

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wait for the CLA tag.

@SylvainDe
Copy link
Contributor Author

@Haypo Thanks for the quick reply. I've just added my Github handle to my profile on the bug.report. Let's wait and see :-)

@vstinner vstinner dismissed their stale review March 27, 2017 21:36

bot is happy

@vstinner vstinner merged commit d67a103 into python:master Mar 27, 2017
@vstinner
Copy link
Member

On this tiny change, I didn't ask you to add yourself to Misc/ACKS, but you may have to do it for your next change.

Thanks for your first contribution to CPython! I made the mistake, but I'm happy that someone found it, and even better, fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants