bpo-29935: Fix error messages in the index() method of tuple, list and deque #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and deque when pass indices of wrong type.
serhiy-storchaka
added
type-bug
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @larryhastings, @benjaminp and @rhettinger to be potential reviewers. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 30, 2017
…and deque (python#887) when pass indices of wrong type. (cherry picked from commit d4edfc9)
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 30, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 30, 2017
…and deque (python#887) (python#907) when pass indices of wrong type. (cherry picked from commit d4edfc9) (cherry picked from commit bf4bb2e)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 30, 2017
…st (python#887) (python#907) when pass indices of wrong type. (cherry picked from commit d4edfc9) (cherry picked from commit bf4bb2e)
This was referenced Mar 30, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 30, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when pass indices of wrong type.
_PyEval_SliceIndex() now checks for None and not check for NULL.
_PyEval_SliceIndexNotNone() is similar to _PyEval_SliceIndex(), but doesn't allow None.