Skip to content

bpo-34551: Remove redundant store #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

ericlippert
Copy link

@ericlippert ericlippert commented Aug 30, 2018

The assignment of i/2 to nk is redundant because on this code path, nk is already the size of the dictionary, and i is already twice the size of the dictionary. I've replaced the store with an assertion that i/2 is equal to nk.

https://bugs.python.org/issue34551

The assignment of i/2 to nk is redundant because on this code path, nk is already the size of the dictionary, and i is already twice the size of the dictionary. I've replaced the store with an assertion that i/2 is nk.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@ericlippert
Copy link
Author

Re: CLA not signed: I am a Facebook employee and we have a company-wide CLA. I'll investigate what incantations I need to perform to ensure that the bot stops flagging me.

@ericlippert
Copy link
Author

I've signed the CLA and commentary on the associated issue indicates that the change is safe; could I please get the "CLA not signed" tag removed? Thanks!

@johnmyleswhite
Copy link

As an outsider, it looks to me like the "skip news" label would apply to this PR and that it would resolve the failing check. Is that right?

@ericlippert
Copy link
Author

Any chance someone could approve this PR?

@ambv ambv merged commit 5a95ba2 into python:master Oct 22, 2018
@ambv
Copy link
Contributor

ambv commented Oct 22, 2018

Merged based on discussion on the issue.

@ambv
Copy link
Contributor

ambv commented Oct 22, 2018

Thank you, @ericlippert.

@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants