Skip to content

gh-91428: Add _PyOpcode_OpName to opcode.h of debug builds #91430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2022

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Apr 10, 2022

@sweeneyde sweeneyde requested a review from brandtbucher April 11, 2022 16:57
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks.

One minor suggestion (makes it a bit easier to spot mistakes):

Comment on lines 114 to 115
for name, op in opmap.items():
fobj.write(f''' [{op}] = "{name}",\n''')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for name, op in opmap.items():
fobj.write(f''' [{op}] = "{name}",\n''')
for name in opmap:
fobj.write(f''' [{name}] = "{name}",\n''')

@sweeneyde sweeneyde merged commit 8a35ce3 into python:main Apr 11, 2022
@sweeneyde sweeneyde deleted the opname branch April 12, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants