bpo-34623: Use XML_SetHashSalt in _elementtree #9146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Sep 11, 2018
| @@ -0,0 +1,2 @@ | |||
| The C accelerated _elementtree module now initializes hash randomization | |||
| salt from _Py_HashSecret instead of libexpat's default CPRNG. | |||
There was a problem hiding this comment.
CPRNG or CSPRNG? :-) Maybe even write "cryptographic pseudo-random number generator (CPRNG)".
serhiy-storchaka
approved these changes
Sep 11, 2018
Include/pyexpat.h
Outdated
| @@ -48,6 +52,9 @@ struct PyExpat_CAPI | |||
| enum XML_Status (*SetEncoding)(XML_Parser parser, const XML_Char *encoding); | |||
| int (*DefaultUnknownEncodingHandler)( | |||
| void *encodingHandlerData, const XML_Char *name, XML_Encoding *info); | |||
| #if PYEXPAT_COMBINED_VERSION >= 20100 | |||
There was a problem hiding this comment.
Couldn't adding the slot conditionally break binary compatibility?
There was a problem hiding this comment.
The new PyExpat_CAPI_MAGIC version ensures that only compatible modules are loaded.
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo34623-xml-setsalt
branch
from
cfc37f3 to
4125d70
Compare
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
|
GH-9392 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
|
GH-9393 is a backport of this pull request to the 3.6 branch. |
|
Sorry, @tiran, I could not cleanly backport this to |
|
GH-9394 is a backport of this pull request to the 2.7 branch. |
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Sep 18, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623. (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 18, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
miss-islington
pushed a commit
that referenced
this pull request
Sep 18, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623. (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623
miss-islington
added a commit
that referenced
this pull request
Sep 18, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Oct 17, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Oct 18, 2018
The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
mingwandroid
pushed a commit
to mingwandroid/cpython
that referenced
this pull request
Feb 18, 2019
…nGH-9394) The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623. (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623
mingwandroid
pushed a commit
to mingwandroid/cpython
that referenced
this pull request
Feb 23, 2019
…nGH-9394) The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623. (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623
larryhastings
pushed a commit
that referenced
this pull request
Feb 25, 2019
* bpo-34623: Use XML_SetHashSalt in _elementtree (GH-9146) The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
larryhastings
pushed a commit
that referenced
this pull request
Feb 25, 2019
* bpo-34623: Use XML_SetHashSalt in _elementtree (GH-9146) The C accelerated _elementtree module now initializes hash randomization salt from _Py_HashSecret instead of libexpat's default CPRNG. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue34623 (cherry picked from commit cb5778f) Co-authored-by: Christian Heimes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C accelerated _elementtree module now initializes hash randomization
salt from _Py_HashSecret instead of libexpat's default CPRNG.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue34623