Post-commit updates for bpo-33073. #9303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Sep 17, 2018
| tests = [10, 0, -10, 1] | ||
| class myint(int): | ||
| pass | ||
| tests = [10, 0, -10, 1, sys.maxsize + 1, True, False, myint(42)] |
There was a problem hiding this comment.
Question: what about the enum.IntEnum tests? (I assume those can be derived from an int subclass but I just want to confirm).
There was a problem hiding this comment.
enum.IntEnum is just an int subclass.
pablogsal
approved these changes
Sep 17, 2018
|
@lisroach, please take a look. |
|
The change LGTM, but got no activity after @pablogsal approved it one month ago. I decided to merge it, since I consider that it enhances the code and I don't want this PR to be forgotten. I changed the commit title, but kept its description. Thanks @serhiy-storchaka, I like new tests :-) cc @lisroach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33073