-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
[3.10] GH-93964: Harden overflow checks before _PyBytes_Resize in compile.c #94045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25d9683
to
9adc696
Compare
I confirmed that this successfully raises instead of crashing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor issues, otherwise LGTM.
When you're done making the requested changes, leave the comment: |
Now it's:
I have made the requested changes; please review again |
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
Thanks. |
#93964