GH-94149: Fix unaligned access in convertsimple(). #94141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like python#6123 this pointer may be unaligned, so a memcpy() instead of simple assignment is required for strict architectures e.g. sparc.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
matoro
changed the title
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Aug 23, 2022
This actually fixes a real bug that normally only would have manifested under specific conditions (possibly crafted input file) but was revealed due to sparc's alignment requirements. Initially misidentified as a cpython bug [1] but the cpython devs helpfully clarified and pointed in the right direction [2]. [1] python/cpython#94141 [2] python/cpython#94149 Bug: https://bugs.gentoo.org/857408 Bug: https://bugs.gentoo.org/865051
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Aug 23, 2022
This actually fixes a real bug that normally only would have manifested under specific conditions (possibly crafted input file) but was revealed due to sparc's alignment requirements. Initially misidentified as a cpython bug [1] but the cpython devs helpfully clarified and pointed in the right direction [2]. [1] python/cpython#94141 [2] python/cpython#94149 Bug: https://bugs.gentoo.org/857408 Bug: https://bugs.gentoo.org/865051
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Aug 23, 2022
This actually fixes a real bug that normally only would have manifested under specific conditions (possibly crafted input file) but was revealed due to sparc's alignment requirements. Initially misidentified as a cpython bug [1] but the cpython devs helpfully clarified and pointed in the right direction [2]. [1] python/cpython#94141 [2] python/cpython#94149 Bug: https://bugs.gentoo.org/857408 Bug: https://bugs.gentoo.org/865051 Closes: #26970 Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #6123 this pointer may be unaligned, so a memcpy() instead of simple assignment is required for strict architectures e.g. sparc.