Skip to content

[3.7] Revert "[3.7] bpo-34589: Add -X coerce_c_locale option; C locale coercion off by default (GH-9379)" #9416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 19, 2018

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think leaving the 3.7 branch alone is the best way to go here, and then we can wrangle at our leisure on how to get the locale coercion implementation back to its as-designed-and-initially-implemented architecture for 3.8+

@vstinner
Copy link
Member Author

Oh wow, I have been bitten by two random CI bugs from the outer space:

  • Travis CI failed because of the random test_socket failure: https://bugs.python.org/issue33937
  • test_subprocess hangs on Windows!? "running: test_subprocess (53 min 15 sec)"

I restarted the Travis CI job.

@vstinner
Copy link
Member Author

Oh, on AppVeyor, test_functools failed a timeout after 20 min on test_parallel_meta_path().

Linux-PR CI failed to build its environment:

2018-09-19T11:14:10.5896975Z E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)

CIs are grumpy today.

@vstinner vstinner closed this Sep 19, 2018
@vstinner vstinner reopened this Sep 19, 2018
@vstinner
Copy link
Member Author

Close/reopen to retrigger AppVeyor job.

@vstinner vstinner merged commit 95cc3ee into python:3.7 Sep 19, 2018
@vstinner vstinner deleted the revert_coerce branch September 19, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants