-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-94772: Fix off-by-one error in Windows launcher #94779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Was just doing a fly-by look at the implementation out of curiosity. Since I'm here, I noticed that there doesn't appear to be a single test which checks a shebang without a space before the first command (e.g. Quoting wikipedia on the issue:
|
+1 on more tests, and the one you suggest seems reasonable. Ideally, I'd test a variety of scripts using parametrised tests, but I'm not sure how to do those in unittest... The main focus of this PR is to fix the regression in the launcher, so I'd suggest extra tests get added in a follow-up PR, though. |
) (cherry picked from commit 407ff65) Co-authored-by: Paul Moore <[email protected]>
GH-94896 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit 407ff65) Co-authored-by: Paul Moore <[email protected]> Co-authored-by: Paul Moore <[email protected]>
Thanks @zooba for merging this. |
Fixes #94772.