Skip to content

gh-94869: Fix the location in some expressions for multi-line f-string ast nodes #94895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 16, 2022

@pablogsal pablogsal merged commit 2e9da8e into python:main Jul 16, 2022
@pablogsal pablogsal deleted the gh-94869 branch July 16, 2022 18:51
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-94910 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 16, 2022
@bedevere-bot
Copy link

GH-94911 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2e9da8e3522764d09f1d6054a2be567e91a30812 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2022
…-string ast nodes (pythonGH-94895)

(cherry picked from commit 2e9da8e)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2022
…-string ast nodes (pythonGH-94895)

(cherry picked from commit 2e9da8e)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
miss-islington added a commit that referenced this pull request Jul 16, 2022
…g ast nodes (GH-94895)

(cherry picked from commit 2e9da8e)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Jul 16, 2022
…g ast nodes (GH-94895) (#94911)

(cherry picked from commit 2e9da8e)

Co-authored-by: Pablo Galindo Salgado <[email protected]>

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@hugovk hugovk removed the needs backport to 3.9 only security fixes label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ast gets the wrong column information for interpolated code in multiline f-strings
4 participants