-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-91212: Fixed flickering when the tracer is turned off #95129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested before and after from a Chromebook Linux runtime, confirmed. Thanks for the fix!
GH-97636 is a backport of this pull request to the 3.11 branch. |
GH-97637 is a backport of this pull request to the 3.10 branch. |
…nGH-95129) Fixed flickering when the tracer is turned off. (cherry picked from commit 4652093) Co-authored-by: Shin-myoung-serp <[email protected]>
…nGH-95129) Fixed flickering when the tracer is turned off. (cherry picked from commit 4652093) Co-authored-by: Shin-myoung-serp <[email protected]>
Fixed flickering when the tracer is turned off. (cherry picked from commit 4652093) Co-authored-by: Shin-myoung-serp <[email protected]>
Fixed flickering when the tracer is turned off. (cherry picked from commit 4652093) Co-authored-by: Shin-myoung-serp <[email protected]>
|
|
|
|
RawTurtle.write() calls RawTurtle._write(), that calls TurtleScreenBase._write(), and finally that calls update() of the underlying canvas.
When the tracer is turned off, the update() of the underlying canvas should not be called.
That is done by removing self.cv.update() inside TurtleScreenBase._write().
But update() of the underlying canvas should be called if the tracer is turned on.
That is done by the added self._update() after self.screen._write() inside RawTurtle._write().