Fix downcast compiler warning in Modules/_testcapi/vectorcall.c #95729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
You're welcome :) BTW, there are still two unused variable warnings. Either we split the test up: set it up in C, perform the test in Python. Or, we add a pragma to avoid the compiler from emitting a warning in release mode. I'd prefer the first, even though it is a larger change. |
|
Hm. It seems those only appeared after they were copied to another file, is that right? Is there some existing pragma or some kind of file-based supression? But that's just me wondering. This should be fixed, I'll continue in #95783. |
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.