Skip to content

bpo-29963: Remove obsolete declaration in tokenizer.h #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2017
Merged

bpo-29963: Remove obsolete declaration in tokenizer.h #962

merged 1 commit into from
Apr 3, 2017

Conversation

DimitrisJim
Copy link
Contributor

Couldn't trace exactly when PyTokenizer_RestoreEncoding was removed from tokenizer.c but the corresponding declaration in the header file survived. PR removes it.

@mention-bot
Copy link

@DimitrisJim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @serhiy-storchaka and @nascheme to be potential reviewers.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Apr 2, 2017
@DimitrisJim
Copy link
Contributor Author

Travis doc build failed with an UnboundLocalError from sphinx/domains/python.py, apparently. I'm not sure if we can try to rebuild them manually to see if this is a one time thing.

@serhiy-storchaka
Copy link
Member

Triggered rebuilding.

@DimitrisJim
Copy link
Contributor Author

Great, thanks Serhiy!

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Apr 2, 2017

Same situation, I can't seem to understand why this is caused, docs build ok locally for me even with make suspicious.

Update: We'll need to wait until sphinx-doc/sphinx/issues/3597 is addressed.

@serhiy-storchaka serhiy-storchaka merged commit cf1958a into python:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants