Fix documentation typo for pathlib.Path.walk #96301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-buttu
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Just a comment for @brettcannon . This example is not the right one to advocate doctests "as much as possible", but also here it was maybe possible to create a TemporaryDirectory in the testsetup directive, and use it for the example
brettcannon
approved these changes
Aug 26, 2022
|
@marco-buttu possibly, but I haven't dug into our doc examples to see if we are doing that much I/O-related stuff to keep doc builds fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.