Skip to content

[2.7] bpo-19225: Lack of c api exceptions doc #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2017
Merged

[2.7] bpo-19225: Lack of c api exceptions doc #964

merged 2 commits into from
Apr 8, 2017

Conversation

cocoatomo
Copy link
Contributor

backports to 2.7 for #881

@cocoatomo
Keep the c-api exception doc up-to-date
88f5f33 
cherry-pick'ed from ec1f5df..e3d6db3 and fix conflict
@cocoatomo
Copy link
Contributor Author

Travis-CI bypassed docs build (https://travis-ci.org/python/cpython/jobs/217905127) for some reason.
Additional build is needed.

@cocoatomo cocoatomo changed the title [2.7] bpo-19225: Lack of c api exceptions doc [Do not merge] [2.7] bpo-19225: Lack of c api exceptions doc Apr 3, 2017
@serhiy-storchaka serhiy-storchaka self-requested a review April 3, 2017 16:28
@cocoatomo cocoatomo mentioned this pull request Apr 4, 2017
Closed
@cocoatomo
Copy link
Contributor Author

Travis-CI bypassed docs build (https://travis-ci.org/python/cpython/jobs/217905127) for some reason.
Additional build is needed.

@serhiy-storchaka Would you like to re-run Travis CI build?

serhiy-storchaka
serhiy-storchaka approved these changes Apr 6, 2017
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this PR ready for merging or I have missed something?

@cocoatomo
Copy link
Contributor Author

Thank you for the review.

I wonder Travis-CI skipped docs build process of CI build.

Docs weren't updated, stopping build process.

(from https://travis-ci.org/python/cpython/jobs/217905127#L159)

@cocoatomo
Copy link
Contributor Author

So, I want to confirm that docs merged with this PR can be built successfully.

@cocoatomo cocoatomo closed this Apr 7, 2017
@cocoatomo cocoatomo reopened this Apr 7, 2017
@cocoatomo
Copy link
Contributor Author

(Sorry, I made a mistake in operation.)

@cocoatomo cocoatomo changed the title [Do not merge] [2.7] bpo-19225: Lack of c api exceptions doc [2.7] bpo-19225: Lack of c api exceptions doc Apr 8, 2017
@cocoatomo
Copy link
Contributor Author

cocoatomo commented Apr 8, 2017 •
edited
Loading

@serhiy-storchaka I have built and checked docs on my local machine. Would you like to merge this PR into the 2.7 branch?

@serhiy-storchaka serhiy-storchaka merged commit 7f85947 into python:2.7 Apr 8, 2017
@cocoatomo cocoatomo deleted the lack-of-c-api-exceptions-doc-2.7 branch April 8, 2017 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocoatomo @serhiy-storchaka @the-knights-who-say-ni