Skip to content

gh-96729: Ensure upgradability between official and buildrelease.bat releases #96755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2022
Merged

gh-96729: Ensure upgradability between official and buildrelease.bat releases #96755

merged 2 commits into from
Sep 12, 2022

Conversation

adang1345
Copy link
Contributor

@adang1345 adang1345 commented Sep 11, 2022

As of ce21a9b, Windows installations
created using buildrelease.bat cannot be used to upgrade to/from official
Python installations. Official Python releases use a RELEASE_URI with a scheme
of http, while buildrelease.bat was changed to use a RELEASE_URI with a
scheme of https. This changes the value in buildrelease.bat to match
that of official releases.
@adang1345 adang1345 requested a review from a team as a code owner September 11, 2022 18:34
@ghost
Copy link

ghost commented Sep 11, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@zooba zooba added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 12, 2022
@zooba zooba merged commit 662782e into python:main Sep 12, 2022
@miss-islington
Copy link
Contributor

Thanks @adang1345 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2022
…at have matching UUIDs with official releases (pythonGH-96755)

(cherry picked from commit 662782e)

Co-authored-by: adang1345 <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 12, 2022
@bedevere-bot
Copy link

GH-96774 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 12, 2022
@bedevere-bot
Copy link

GH-96775 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2022
…at have matching UUIDs with official releases (pythonGH-96755)

(cherry picked from commit 662782e)

Co-authored-by: adang1345 <[email protected]>
@zooba
Copy link
Member

zooba commented Sep 12, 2022

Thanks for the fix! I'm backporting this, because it's most important for people building old releases with additional patches. (It won't be in 3.11.0, but that's fine)

miss-islington added a commit that referenced this pull request Sep 12, 2022
…e matching UUIDs with official releases (GH-96755)

(cherry picked from commit 662782e)

Co-authored-by: adang1345 <[email protected]>
@adang1345 adang1345 deleted the fix-96729 branch September 12, 2022 15:21
zooba pushed a commit that referenced this pull request Sep 14, 2022
…e matching UUIDs with official releases (GH-96755)

(cherry picked from commit 662782e)

Co-authored-by: adang1345 <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 24, 2022
…e matching UUIDs with official releases (GH-96755)

(cherry picked from commit 662782e)

Co-authored-by: adang1345 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants