gh-77171 Support WAVE_FORMAT_EXTENSIBLE in the wave module #96777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test file, a modified version of Lib/test/audiodata/pluck-pcm24.wav, was provided by Andrea Celletti on the bug tracker.
|
All commit authors signed the Contributor License Agreement. |
|
@zooba |
|
LGTM, thanks! |
|
Thank you for reviewing and merging this! Maybe we can backport this? |
|
I'm unsure whether to backport, so I started a thread to get other opinions. |
|
I've decided not to backport, as the variation between micro releases may be surprising and make it harder to predict whether a file will open. pedalboard is a good alternative for reading/writing files on earlier versions. |
|
Thank you for considering, updating the doc and the bugfix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took over the original PR #9515 and created this new PR since the original one seems abandoned.
I rebased @ZackerySpytz's work on the current
mainand resolved some conflicts. Then changed some code to meet the reviewer's request which made for the original PR.