-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-96947: Fix comment on pyruntimestate->pyinterpreters
struct for next_id
#96949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
pyruntimestate->pyinterpreters
struct for next_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix! |
FYI, I chose to not backport this. I'm not convinced it matters enough (though it is certainly worth correcting in main). |
_next_interp_id
appeared on this commit renamed tonext_id
(by this commit).Also, now,
next_id
gets initialized in_PyInterpreterState_Enable()
cpython/Python/pystate.c
Lines 241 to 244 in 12c5f32
_PyInterpreterState_Init()
function doesn't exist at all.pyruntimestate->pyinterpreters
struct fornext_id
#96947Automerge-Triggered-By: GH:ericsnowcurrently