Skip to content

gh-96947: Fix comment on pyruntimestate->pyinterpreters struct for next_id #96949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

vitaldmit
Copy link
Contributor

@vitaldmit vitaldmit commented Sep 20, 2022

_next_interp_id appeared on this commit renamed to next_id (by this commit).

Also, now, next_id gets initialized in _PyInterpreterState_Enable()

cpython/Python/pystate.c

Lines 241 to 244 in 12c5f32

_PyInterpreterState_Enable(_PyRuntimeState *runtime)
{
struct pyinterpreters *interpreters = &runtime->interpreters;
interpreters->next_id = 0;
because _PyInterpreterState_Init() function doesn't exist at all.

Automerge-Triggered-By: GH:ericsnowcurrently

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Sep 20, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@vitaldmit vitaldmit changed the title Fix comment on pyruntimestate->pyinterpreters struct gh-96947: Fix comment on pyruntimestate->pyinterpreters struct Sep 20, 2022
@vitaldmit vitaldmit changed the title gh-96947: Fix comment on pyruntimestate->pyinterpreters struct gh-96947: Fix comment on pyruntimestate->pyinterpreters struct for next_id Sep 20, 2022
@vitaldmit vitaldmit changed the title gh-96947: Fix comment on pyruntimestate->pyinterpreters struct for next_id gh-96947: Fix comment on pyruntimestate->pyinterpreters struct for next_id Sep 20, 2022
Copy link
Contributor Author

@vitaldmit vitaldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link
Member

Thanks for the fix!

@ericsnowcurrently
Copy link
Member

FYI, I chose to not backport this. I'm not convinced it matters enough (though it is certainly worth correcting in main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants