-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-32995 - Added context variable in glossary #9741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-32995 - Added context variable in glossary #9741
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should link the contextvars module, not the PEP
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected.
Doc/glossary.rst
Outdated
@@ -221,6 +221,14 @@ Glossary | |||
statement by defining :meth:`__enter__` and :meth:`__exit__` methods. | |||
See :pep:`343`. | |||
|
|||
context variable | |||
A variable which can have different values depending on it's context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be its context
instead of it's context
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Doc/glossary.rst
Outdated
context variable | ||
A variable which can have different values depending on it's context. | ||
This is similar to TLS(Thread Local Storage) in which each execution | ||
thread may have a different value for a variable. In case of context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/In case of context/In the case of a context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have re-written that part of sentence which Iam now satisfied with.
Kindly let me know ur comments.
Doc/glossary.rst
Outdated
A variable which can have different values depending on it's context. | ||
This is similar to TLS(Thread Local Storage) in which each execution | ||
thread may have a different value for a variable. In case of context | ||
variable, there may be sevaral contexts in one execution thread and it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/sevaral/several
ebfa942
to
2c9e59f
Compare
I have made the requested changes; please review again |
Thanks for making the requested changes! @1st1: please review the changes made to this pull request. |
@the-knights-who-say-ni , I have signed the CLA. Not sure why its still showing as 'CLA not signed'. |
Thanks @the-knights-who-say-ni . |
(cherry picked from commit c0a1a07) Co-authored-by: Vinodhini Balusamy <[email protected]>
GH-13311 is a backport of this pull request to the 3.7 branch. |
@vinu2003 Thank you for the contribution to CPython! 🎉 🎉 |
(cherry picked from commit c0a1a07) Co-authored-by: Vinodhini Balusamy <[email protected]>
bpo-32995 Added context variable in glossary.rst
https://bugs.python.org/issue32995