bpo-34940: Fix the error handling in _check_for_legacy_statements() #9764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Objects/exceptions.c
Outdated
| if (PyUnicode_Tailmatch(self->text, print_prefix, | ||
| start, text_len, -1)) { | ||
|
|
||
| Py_ssize_t match = PyUnicode_Tailmatch(self->text, print_prefix, |
There was a problem hiding this comment.
For symmetry with "exec" I suggest to move the match variable declaration to the beginning of the function.
Objects/exceptions.c
Outdated
| if (match == -1) { | ||
| return -1; | ||
| } | ||
| if (match == 1) { |
There was a problem hiding this comment.
Since match is a boolean here, I prefer to use just if (match) instead of if (match == 1).
Objects/exceptions.c
Outdated
| Py_XSETREF(self->msg, | ||
| PyUnicode_FromString("Missing parentheses in call to 'exec'")); | ||
| if (self->msg == NULL) { |
There was a problem hiding this comment.
Check for NULL before modifying self->msg.
|
Thank you, @serhiy-storchaka, for reviewing my patches. |
serhiy-storchaka
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34940