Skip to content

bpo-23831: Add moveto method to the tkinter.Canvas widget #9768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/whatsnew/3.8.rst
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ Added methods :meth:`~tkinter.Spinbox.selection_from`,
in the :class:`tkinter.Spinbox` class.
(Contributed by Juliette Monsel in :issue:`34829`.)

Added method :meth:`~tkinter.Canvas.moveto`
in the :class:`tkinter.Canvas` class.
(Contributed by Juliette Monsel in :issue:`23831`.)

venv
----

Expand Down
9 changes: 9 additions & 0 deletions Lib/tkinter/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2914,6 +2914,15 @@ def move(self, *args):
"""Move an item TAGORID given in ARGS."""
self.tk.call((self._w, 'move') + args)

def moveto(self, tagOrId, x='', y=''):
"""Move the items given by TAGORID in the canvas coordinate
space so that the first coordinate pair of the bottommost
item with tag TAGORID is located at position (X,Y).
X and Y may be the empty string, in which case the
corresponding coordinate will be unchanged. All items matching
TAGORID remain in the same positions relative to each other."""
self.tk.call(self._w, 'moveto', tagOrId, x, y)

def postscript(self, cnf={}, **kw):
"""Print the contents of the canvas to a postscript
file. Valid options: colormap, colormode, file, fontmap,
Expand Down
23 changes: 23 additions & 0 deletions Lib/tkinter/test/test_tkinter/test_widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,29 @@ def test_yscrollincrement(self):
self.checkPixelsParam(widget, 'yscrollincrement',
10, 0, 11.2, 13.6, -10, '0.1i')

@requires_tcl(8, 6)
def test_moveto(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decorate this test as requiring Tk 8.6.

widget = self.create()
i1 = widget.create_rectangle(1, 1, 20, 20, tags='group')
i2 = widget.create_rectangle(30, 30, 50, 70, tags='group')
x1, y1, _, _ = widget.bbox(i1)
x2, y2, _, _ = widget.bbox(i2)
widget.moveto('group', 200, 100)
x1_2, y1_2, _, _ = widget.bbox(i1)
x2_2, y2_2, _, _ = widget.bbox(i2)
self.assertEqual(x1_2, 200)
self.assertEqual(y1_2, 100)
self.assertEqual(x2 - x1, x2_2 - x1_2)
self.assertEqual(y2 - y1, y2_2 - y1_2)
widget.tag_lower(i2, i1)
widget.moveto('group', y=50)
x1_3, y1_3, _, _ = widget.bbox(i1)
x2_3, y2_3, _, _ = widget.bbox(i2)
self.assertEqual(y2_3, 50)
self.assertEqual(x2_3, x2_2)
self.assertEqual(x2_2 - x1_2, x2_3 - x1_3)
self.assertEqual(y2_2 - y1_2, y2_3 - y1_3)


@add_standard_options(IntegerSizeTests, StandardOptionsTests)
class ListboxTest(AbstractWidgetTest, unittest.TestCase):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add ``moveto()`` method to the ``tkinter.Canvas`` widget. Patch by Juliette
Monsel.