Skip to content

bpo-35138: Added an example for timeit.timeit with callable arguments #9787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2019
Merged

bpo-35138: Added an example for timeit.timeit with callable arguments #9787

merged 3 commits into from
May 13, 2019

Conversation

boxed
Copy link
Contributor

@boxed boxed commented Oct 10, 2018 •
edited by bedevere-bot
Loading

The timeit module has a feature that is documented, but seems so hard to spot in the docs that it is easily missed. This PR adds a small example to make this feature easier to spot.

See python-ideas discussion: https://groups.google.com/forum/#!topic/python-ideas/0HzCEj0H9NM

https://bugs.python.org/issue35138

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 10, 2018
tirkarthi
tirkarthi approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍 Good to know that I can use callables which is more friendly instead of code as strings :)

@berkerpeksag berkerpeksag changed the title Added an example for timeit.timeit with callable arguments bpo-35138: Added an example for timeit.timeit with callable arguments Nov 1, 2018
berkerpeksag
berkerpeksag requested changes Nov 1, 2018
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@boxed
Copy link
Contributor Author

boxed commented May 13, 2019

Can someone help? I think I've fixed the requested changes and marked them as complete but it still looks like it's waiting for changes...

@tirkarthi
Copy link
Member

tirkarthi commented May 13, 2019 •
edited
Loading

You need to add the below comment so that the bot can toggle the status.

"I have made the requested changes; please review again"

@boxed
Copy link
Contributor Author

boxed commented May 13, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@vstinner vstinner merged commit 8da5ebe into python:master May 13, 2019
@miss-islington
Copy link
Contributor

Thanks @boxed for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2019
@boxed @miss-islington
bpo-35138: Added an example for timeit.timeit with callable arguments (…
21cff3d 
…pythonGH-9787)

* Update timeit.rst
(cherry picked from commit 8da5ebe)

Co-authored-by: Anders Hovmöller <[email protected]>
@bedevere-bot
Copy link

GH-13295 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Thanks @boxed for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington added a commit that referenced this pull request May 13, 2019
@miss-islington @boxed
bpo-35138: Added an example for timeit.timeit with callable arguments (…
7f485ea 
…GH-9787)

* Update timeit.rst
(cherry picked from commit 8da5ebe)

Co-authored-by: Anders Hovmöller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@davidak davidak davidak approved these changes

@4383 4383 4383 approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@boxed @bedevere-bot @vstinner @tirkarthi @miss-islington @berkerpeksag @davidak @4383 @serhiy-storchaka @the-knights-who-say-ni