Skip to content

bpo-29972: Skip tests known to fail on AIX #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2017
Merged

bpo-29972: Skip tests known to fail on AIX #979

merged 3 commits into from
Apr 4, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 3, 2017

See http://bugs.python.org/issue29972 for more information.

@vstinner
bpo-29972: Fix test_eintr on AIX
f224de0 
On AIX, sigtimedwait(0.2) sleeps 199.8 ms, whereas the test expects
200 ms or longer.
@vstinner
Copy link
Member Author

vstinner commented Apr 3, 2017

@edelsohn: Can you please try this change on AIX? (I'm unable to test my change.)

@vstinner
bpo-29972: Skip some inet_pton() tests on AIX
2f6f3e6 
Skip some inet_pton() tests of test_socket on AIX.

inet_pton() on AIX is less strict than on Linux and doesn't reject
some invalid IP addresses. The unit tests test more the libc than
Python itself.
@vstinner
Copy link
Member Author

vstinner commented Apr 3, 2017

(Oops, I forgot some "import sys", it should now be fixed.)

@edelsohn
Copy link

edelsohn commented Apr 3, 2017

With the patches,

test_eintr
test_locale
test_strptime

succeed.

test_socket fails with

FAIL: testIPv6toString (test.test_socket.GeneralModuleTests)

Traceback (most recent call last):
File "/scratch/dje/src/cpython/Lib/test/test_socket.py", line 1090, in testIPv6toString
assertInvalid('1:2:3:4:5:6:7:8:')
File "/scratch/dje/src/cpython/Lib/test/test_socket.py", line 1066, in
(OSError, ValueError), f, a
AssertionError: (<class 'OSError'>, <class 'ValueError'>) not raised by

with a similar guard for the '1:2:3:4:5:6:7:8:' test, it succeeds.

test_tools fails because test_tools/test_i18n.py needs to import sys. With that change, it succeeds.

edelsohn
edelsohn reviewed Apr 3, 2017
View reviewed changes
Lib/test/test_socket.py Outdated
assertInvalid('1:2:3:4:5:6:')
# bpo-29972: inet_pton() doesn't fail on AIX
if not sys.platform.startswith('aix'):
assertInvalid('1:2:3:4:5:6:')
assertInvalid('1:2:3:4:5:6')
assertInvalid('1:2:3:4:5:6:7:8:')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'1:2:3:4:5:6:7:8:' needs to be guarded on AIX also.

@vstinner
bpo-29972: Skip tests known to fail on AIX
512df22 
* test_locale.test_strcoll_with_diacritic()
* test_locale.test_strxfrm_with_diacritic()
* test_strptime.test_week_of_year_and_day_of_week_calculation()
* test_tools.test_POT_Creation_Date()
@vstinner
Copy link
Member Author

vstinner commented Apr 3, 2017

I already added "import sys" to test_tools/test_i18n.py, maybe you picked the old version of my PR?

'1:2:3:4:5:6:7:8:' needs to be guarded on AIX also.

Ok, done. Can you please test again?

@edelsohn
Copy link

edelsohn commented Apr 4, 2017 via email

@vstinner vstinner merged commit 5de85a1 into python:master Apr 4, 2017
@vstinner vstinner deleted the skip_aix branch April 4, 2017 08:35
@vstinner
Copy link
Member Author

vstinner commented Apr 4, 2017

Ok, I merged this first changes to fix (skip) a few unit tests on the AIX buildbot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelsohn edelsohn edelsohn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @edelsohn @the-knights-who-say-ni