Skip to content

bpo-34748: link to :ref:partial-objects in functools doc. #9809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

bpo-34748: link to :ref:partial-objects in functools doc. #9809

merged 1 commit into from
Oct 23, 2018

Conversation

andreip
Copy link
Contributor

@andreip andreip commented Oct 12, 2018 •
edited by bedevere-bot
Loading

https://bugs.python.org/issue34748

  • Needs backport to 2.7, 3.6, 3.7

The PR just changes

:class:`partial` object

into

:ref:`partial object<partial-objects>`

There are some more mentions of partial objects at the bottom in the partial objects section, but I don't think it's needed to change those links as well -- it's obvious that you're talking about the partial objects you're currently at, that section is pretty short.

https://bugs.python.org/issue34748

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 12, 2018
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

tirkarthi
tirkarthi approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the PR locally and looks good to me. Approving. Thanks for the PR 👍

@zhangyangyu zhangyangyu merged commit 83a0765 into python:master Oct 23, 2018
@miss-islington
Copy link
Contributor

Thanks @andreip for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-10046 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2018
@andreip @miss-islington
bpo-34748: link to :ref:partial-objects in functools.partial doc. (p…
76fbb81 
…ythonGH-9809)

(cherry picked from commit 83a0765)

Co-authored-by: Andrei Petre <[email protected]>
@bedevere-bot
Copy link

GH-10047 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @andreip and @zhangyangyu, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 83a07652e0033f0d9994ae7634b91d6581c56b00 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2018
@andreip @miss-islington
bpo-34748: link to :ref:partial-objects in functools.partial doc. (p…
9a48e5f 
…ythonGH-9809)

(cherry picked from commit 83a0765)

Co-authored-by: Andrei Petre <[email protected]>
miss-islington added a commit that referenced this pull request Oct 23, 2018
@miss-islington @andreip
bpo-34748: link to :ref:partial-objects in functools.partial doc. (G…
fc62c72 
…H-9809)

(cherry picked from commit 83a0765)

Co-authored-by: Andrei Petre <[email protected]>
miss-islington added a commit that referenced this pull request Oct 23, 2018
@miss-islington @andreip
bpo-34748: link to :ref:partial-objects in functools.partial doc. (G…
42892a2 
…H-9809)

(cherry picked from commit 83a0765)

Co-authored-by: Andrei Petre <[email protected]>
zhangyangyu added a commit that referenced this pull request Oct 23, 2018
@zhangyangyu
[2.7] bpo-34748: link to :ref:partial-objects in functools.partial …
a4499db 
…doc. (GH-9809)

(cherry picked from commit 83a0765)

Co-authored-by: Andrei Petre [email protected]
@bedevere-bot
Copy link

GH-10048 is a backport of this pull request to the 2.7 branch.

zhangyangyu added a commit that referenced this pull request Oct 23, 2018
@zhangyangyu
[2.7] bpo-34748: link to :ref:partial-objects in functools.partial …
56a4a3a 
…doc. (GH-9809)

(cherry picked from commit 83a0765)

Co-authored-by: Andrei Petre [email protected]
@andreip andreip deleted the bpo-34748 branch October 23, 2018 16:58
@andreip
Copy link
Contributor Author

andreip commented Oct 23, 2018

@zhangyangyu thanks for merging this! @tirkarthi thanks for your review!

Any idea why 3.8 docs don't yet reflect the changes added here? I expected it would mirror master branch. Verified and 2.7, 3.6, 3.7 are all fine, they reflect the new changes. Can search for "partial object" in the docs.

@tirkarthi
Copy link
Member

@andreip You're welcome :) On the bottom of the page it says October 21 as last updated for 3.8 while others say October 23. I am not aware of the doc build cycle for the respective branches though though build scripts are at https://github.com/python/docsbuild-scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@zhangyangyu zhangyangyu

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andreip @the-knights-who-say-ni @miss-islington @bedevere-bot @tirkarthi @zhangyangyu