gh-98878: Use builtins from the bound frame when offering a suggestion #98880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
changed the title
|
Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @isidentical and @pablogsal, I could not cleanly backport this to |
|
Ahhh, the backport fairy strikes again :( |
I thought we had this only on 3.12 (this is the Python implementation of the suggestion logic), no? @pablogsal |
|
Ah, right, for some reason I through we backported this 🤔 This makes me think that the lack of parity may be a bug and we should consider backporting it but oh well 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__builtins__value in the globals can be either a dictionary or a module. This PR allows it to be handled in either way (by actually using the frame builtins instead of the__builtins__object).